feat: make cluster domain configurable in KEDA deployer#3682
feat: make cluster domain configurable in KEDA deployer#3682Itx-Psycho0 wants to merge 1 commit intoknative:mainfrom
Conversation
This commit addresses issue knative#3403 by making the cluster domain configurable for KEDA deployments. Changes: - Added ClusterDomain field to DeploySpec in pkg/functions/function.go - Updated KEDA deployer to use configurable cluster domain with 'cluster.local' as the default fallback - Added unit tests to verify the cluster domain configuration works correctly with default, custom, and explicit values The external name service to keda-add-ons-http-interceptor-proxy now uses the configured cluster domain instead of being hardcoded to 'cluster.local'. This allows the function to work in clusters with custom domain configurations. Fixes knative#3403
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Itx-Psycho0 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
knative-prow
Bot
added
size/L
|
Hi @Itx-Psycho0. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi maintainers, I've implemented a fix for issue #3403 that makes the cluster domain configurable in the KEDA deployer. Summary:
The implementation is backward compatible and follows the existing patterns in the codebase. All tests pass and linting is clean. I'd appreciate your review when you have a chance. @lkingland @creydr @matejvasek Thanks! |
1 participant
Problem
The external name service to the keda-add-ons-http-interceptor-proxy was hardcoded with the cluster domain set to
cluster.local. This works for most cases, but fails in clusters with custom domain configurations.Solution
Made the cluster domain configurable by adding a
ClusterDomainfield to theDeploySpecstruct. The KEDA deployer now uses this field to build the interceptor proxy service URL, withcluster.localas the default fallback for backward compatibility.Changes
ClusterDomainfield toDeploySpecinpkg/functions/function.gointerceptorBridgeService()inpkg/keda/deployer.goto use the configurable cluster domainpkg/keda/deployer_test.goto verify the functionalityUsage
Users can now configure the cluster domain in their
func.yaml:Testing
✅ All unit tests pass
✅ Linting checks pass
✅ Backward compatible (defaults to "cluster.local")
Fixes #3403